Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): remove all compiled files from git #2238

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Apr 29, 2024

Summary

The compiled files should not be added to git.

The new workflow will run prebundle before running the build command, and let Nx to cache the prebundle outputs.

Pros:

  • No need to manually run prebundle script after bump dependencies versions.
  • Avoid polluting git history.

Cons:

  • Takes more time to setup the repo (about 10s)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit a9ddf37
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/662f57c87559a10008ea4633
😎 Deploy Preview https://deploy-preview-2238--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 41f7aa5 into main Apr 29, 2024
9 of 11 checks passed
@chenjiahan chenjiahan deleted the compiled_gitignore_0429 branch April 29, 2024 08:58
@chenjiahan chenjiahan mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant