Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: make RsbuildPluginAPI readonly #1998

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Apr 4, 2024

Summary

Make RsbuildPluginAPI readonly to prevent unexpected modifications.

#1972 (comment)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit c142642
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/660e324309845000080f1b7b
😎 Deploy Preview https://deploy-preview-1998--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 9ef8882 into main Apr 4, 2024
12 checks passed
@chenjiahan chenjiahan deleted the plugin_api_readonly_0404 branch April 4, 2024 05:01
@chenjiahan chenjiahan mentioned this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant