Pass complex object by reference to lambdas

IB-7930

Signed-off-by: Mart Somermaa <[email protected]>

src/ui/webeiddialog.cpp

@@ -341,7 +341,7 @@ void WebEidDialog::onMultipleCertificatesReady(
                     ui->pinInput->clear();
                     onMultipleCertificatesReady(origin, certificateAndPinInfos);
                 });
-        setupOK([this, origin, certificateAndPinInfos] {
+        setupOK([this, &origin] {
             // Authenticate continues with the selected certificate to onSingleCertificateReady().
             if (auto* button =
                     qobject_cast<CertificateButton*>(ui->selectionGroup->checkedButton())) {
@@ -376,7 +376,7 @@ void WebEidDialog::onSingleCertificateReady(const QUrl& origin,
     switch (currentCommand) {
     case CommandType::GET_SIGNING_CERTIFICATE:
         setupCertificateAndPinInfo({certAndPin});
-        setupOK([this, certAndPin] { emit accepted(certAndPin); });
+        setupOK([this, &certAndPin] { emit accepted(certAndPin); });
         ui->selectionGroup->buttons().at(0)->click();
         ui->pageStack->setCurrentIndex(int(Page::SELECT_CERTIFICATE));
         return;
@@ -541,7 +541,7 @@ void WebEidDialog::setTrText(QWidget* label, Text text) const
 void WebEidDialog::connectOkToCachePinAndEmitSelectedCertificate(
     const CardCertificateAndPinInfo& certAndPin)
 {
-    setupOK([this, certAndPin = std::forward<const CardCertificateAndPinInfo&>(certAndPin)] {
+    setupOK([this, &certAndPin] {
         ui->pinInput->hide();
         ui->pinTitleLabel->hide();
         ui->pinErrorLabel->hide();
@@ -592,7 +592,7 @@ void WebEidDialog::setupPinPrompt(const PinInfo& pinInfo)
     ui->pinErrorLabel->setVisible(showPinError);
     showPinInputWarning(showPinError);
     if (showPinError) {
-        setTrText(ui->pinErrorLabel, [pinInfo]() -> QString {
+        setTrText(ui->pinErrorLabel, [&pinInfo]() -> QString {
             return tr("The PIN has been entered incorrectly at least once. %n attempts left.",
                       nullptr, int(pinInfo.pinRetriesCount.first));
         });