Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta/migrate classes priv to pub #713

Merged
merged 8 commits into from
Jan 12, 2024

Conversation

tsmith023
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 208 lines in your changes are missing coverage. Please review.

Comparison is base (a26557b) 89.38% compared to head (97d3ef0) 89.47%.
Report is 111 commits behind head on beta/v4.0.

Files Patch % Lines
integration/test_collection_openai.py 29.62% 38 Missing ⚠️
weaviate/collections/batch/base.py 82.99% 25 Missing ⚠️
integration/test_collection_rerank.py 26.31% 14 Missing ⚠️
weaviate/collections/batch/batch_wrapper.py 80.95% 12 Missing ⚠️
...eaviate/collections/queries/near_audio/group_by.py 75.00% 8 Missing ⚠️
...eaviate/collections/queries/near_image/group_by.py 75.00% 8 Missing ⚠️
...eaviate/collections/queries/near_video/group_by.py 75.00% 8 Missing ⚠️
weaviate/collections/batch/grpc.py 83.33% 7 Missing ⚠️
weaviate/collections/queries/base.py 79.31% 6 Missing ⚠️
...aviate/collections/queries/near_object/group_by.py 80.64% 6 Missing ⚠️
... and 30 more
Additional details and impacted files
@@              Coverage Diff              @@
##           beta/v4.0     #713      +/-   ##
=============================================
+ Coverage      89.38%   89.47%   +0.08%     
=============================================
  Files            154      172      +18     
  Lines          16747    17271     +524     
=============================================
+ Hits           14970    15453     +483     
- Misses          1777     1818      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 marked this pull request as ready for review January 11, 2024 14:56
@tsmith023 tsmith023 requested a review from dirkkul January 11, 2024 14:56
.pre-commit-config.yaml Outdated Show resolved Hide resolved
weaviate/classes/__init__.py Outdated Show resolved Hide resolved
@tsmith023
Copy link
Collaborator Author

As a note, we can add docstrings to the TypeAliases in another PR that is dedicated to docstring tidy-up

@tsmith023 tsmith023 merged commit 71a72e2 into beta/v4.0 Jan 12, 2024
35 checks passed
@tsmith023 tsmith023 deleted the beta/migrate-classes-priv-to-pub branch January 12, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants