Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper class for id and creation/updateTime filtering #635

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Dec 7, 2023

Adds:

  • FilterMetadata.FilterById.equal/not_equal/contains(UUID1)
  • FilterMetadata.FilterByCreationTime.equal/..the rest...(UUID1)
  • FilterMetadata.FilterByUpdateTime.equal(UUID1)

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 194 lines in your changes are missing coverage. Please review.

Comparison is base (7c00d95) 90.37% compared to head (c4554d0) 89.86%.
Report is 147 commits behind head on beta/v4.0.

Files Patch % Lines
weaviate/proto/v1/search_get_pb2.py 0.00% 33 Missing ⚠️
weaviate/collections/queries/base.py 72.85% 19 Missing ⚠️
weaviate/proto/v1/base_pb2.py 0.00% 15 Missing ⚠️
weaviate/client.py 30.00% 14 Missing ⚠️
weaviate/backup/backup.py 87.12% 13 Missing ⚠️
integration/test_backup_v4.py 92.71% 11 Missing ⚠️
integration/test_collection_config.py 65.62% 11 Missing ⚠️
weaviate/proto/v1/batch_pb2.py 0.00% 11 Missing ⚠️
weaviate/connect/helpers.py 28.57% 10 Missing ⚠️
weaviate/collections/classes/config.py 95.61% 5 Missing ⚠️
... and 30 more
Additional details and impacted files
@@              Coverage Diff              @@
##           beta/v4.0     #635      +/-   ##
=============================================
- Coverage      90.37%   89.86%   -0.52%     
=============================================
  Files            132      133       +1     
  Lines          14827    15279     +452     
=============================================
+ Hits           13400    13730     +330     
- Misses          1427     1549     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 merged commit 57e6d49 into beta/v4.0 Dec 7, 2023
23 checks passed
@tsmith023 tsmith023 deleted the metadata_filter_uuid branch December 7, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants