Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use byte vectors instead of repeated floats #629

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Dec 3, 2023

No description provided.

@dirkkul dirkkul requested a review from a team as a code owner December 3, 2023 11:18
@codecov-commenter
Copy link

Codecov Report

Attention: 193 lines in your changes are missing coverage. Please review.

Comparison is base (7c00d95) 90.37% compared to head (0b28d7a) 89.74%.
Report is 139 commits behind head on beta/v4.0.

Files Patch % Lines
weaviate/proto/v1/search_get_pb2.py 0.00% 33 Missing ⚠️
weaviate/collections/queries/base.py 72.85% 19 Missing ⚠️
weaviate/proto/v1/base_pb2.py 0.00% 15 Missing ⚠️
weaviate/client.py 30.00% 14 Missing ⚠️
weaviate/backup/backup.py 87.12% 13 Missing ⚠️
integration/test_backup_v4.py 92.71% 11 Missing ⚠️
integration/test_collection_config.py 65.62% 11 Missing ⚠️
weaviate/proto/v1/batch_pb2.py 0.00% 11 Missing ⚠️
weaviate/connect/helpers.py 28.57% 10 Missing ⚠️
weaviate/collections/classes/config.py 95.61% 5 Missing ⚠️
... and 29 more
Additional details and impacted files
@@              Coverage Diff              @@
##           beta/v4.0     #629      +/-   ##
=============================================
- Coverage      90.37%   89.74%   -0.63%     
=============================================
  Files            132      133       +1     
  Lines          14827    15108     +281     
=============================================
+ Hits           13400    13559     +159     
- Misses          1427     1549     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul changed the title More byte vectors Use byte vectors instead of repeated floats Dec 4, 2023
Copy link
Collaborator

@tsmith023 tsmith023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice profiling tests :)

@dirkkul dirkkul merged commit 0a8c593 into beta/v4.0 Dec 4, 2023
23 checks passed
@dirkkul dirkkul deleted the more_byte_vectors branch January 4, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants