Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow authentification via 'additional_headers' #267

Merged

Conversation

dennis-ge
Copy link
Contributor

fixes #265

Test 'test_auth_header_with_catchall_proxy' was modified because the OIDC configuration endpoint is not called anymore when the authentication is provided via the 'additional_headers' parameter. Apart from 'ApiAuthKey' any other auth method can be used.

fixes weaviate#265

Test 'test_auth_header_with_catchall_proxy' was modified because the
OIDC configuration endpoint is not called anymore when the
authentication is provided via the 'additional_headers' parameter. Apart
from 'ApiAuthKey' any other auth method can be used.
mock_tests/test_auth.py Outdated Show resolved Hide resolved
@weaviate-git-bot
Copy link

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the SeMI bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@dennis-ge
Copy link
Contributor Author

I agree with the CLA

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.51 ⚠️

Comparison is base (c59d7d6) 96.42% compared to head (ac7660b) 95.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   96.42%   95.92%   -0.51%     
==========================================
  Files          64       64              
  Lines        7561     7564       +3     
==========================================
- Hits         7291     7256      -35     
- Misses        270      308      +38     
Flag Coverage Δ
unittests 95.92% <100.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
weaviate/connect/connection.py 90.33% <100.00%> (-0.35%) ⬇️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dirkkul dirkkul merged commit 67de591 into weaviate:main Mar 20, 2023
@dirkkul
Copy link
Collaborator

dirkkul commented Mar 20, 2023

thanks a bunch for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication with additional_headers is not possible
4 participants