This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Attach containers from Proxy using Go code #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
issues/1940-remove-proxy-attach-dep
branch
from
481c423 to
0273491
Compare
implies change type of docker client to weavedocker so we can call things like Info() on it
also specify that it needs no container network
Note we don't need to propagate shell-script env vars now
marccarre
reviewed
May 12, 2017
| @@ -25,42 +23,6 @@ var ( | |||
| Log = common.Log | |||
| ) | |||
|
|
|||
| func callWeave(args ...string) ([]byte, []byte, error) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than calling out to the shell script.
This is the last part to fix #1940