This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Parallelise setup.sh's individual tasks. #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccarre
force-pushed
the
2647-parallelise-setup
branch
5 times, most recently
from
3cdeb6e to
56d1140
Compare
marccarre
force-pushed
the
2647-parallelise-setup
branch
from
56d1140 to
c2bb542
Compare
marccarre
force-pushed
the
2647-parallelise-setup
branch
from
c2bb542 to
e834932
Compare
bboreham
reviewed
Jan 9, 2017
| pull_if_missing() { | ||
| if ! exists_on "$1" "$2" ; then | ||
| echo "Pulling $2 on $1..." | ||
| docker_on $1 pull $2 >/dev/null 2>&1 |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
bboreham
suggested changes
Jan 9, 2017
marccarre
force-pushed
the
2647-parallelise-setup
branch
from
e834932 to
89e1169
Compare
|
As suggested, I removed the redirect of |
bboreham
approved these changes
Jan 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent running the setup steps becomes a blocker when trying to ramp up the number of test servers, given we are currently mainly blocking on I/O -- i.e. many files are uploaded/downloaded, which could easily be done faster.
This is a pre-change refactoring for the #2647 and #2648 work.