This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Transfer IPAM ranges to UnknownPeer if no peer is found during Shutdown #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no peer for transfer is found, we transfer them to mesh.UnknownPeerName to notify the ring update tracker. Makes the awsvpc tracker to remove local entries from the VPC route table when the last peer calls "weave reset".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Shutdown, if no peer for transfer is found, we transfer them tomesh.UnknownPeerNameto notify the ring update tracker.Resolves an issue, when the stale entries are left in the AWS VPC route table after
weave resetissued on the last peer.Fixes #2322 (comment)