This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Add AWSVPC #2341
Merged
Add AWSVPC #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| @@ -540,11 +544,11 @@ func TestClaimForPeers(t *testing.T) { | |||
| // Different end to usual so we get a number of addresses that a) | |||
| // is smaller than the max number of peers, and b) is divisible by | |||
| // some number of peers. This maximises coverage of edge cases. | |||
| end := dot10 | |||
| end := dot8 | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
bboreham
force-pushed
the
issues/2017-awsvpc
branch
from
7c58774 to
758445f
Compare
| @@ -1285,6 +1286,13 @@ ipam_cidrs() { | |||
| allocate) | |||
| METHOD=POST | |||
| CHECK_ALIVE="?check-alive=true" | |||
| # If we get an error here, we skip applying necessary steps for AWSVPC, because | |||
| # "attach" should work without the weave router running. | |||
| [ "$(call_weave GET /ipinfo/tracker)" != "awsvpc" ] || AWSVPC=1 | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
bboreham
force-pushed
the
issues/2017-awsvpc
branch
2 times, most recently
from
d29afb5 to
686a109
Compare
An instance of the interface must implement the HandleUpdate method which (in the future) will be called when any change to the IPAM ring occurs.
The tracker is responsible for managing the AWSVPC route tables which is used to implement the underlay routing based on VPC.
The tracker's HandleUpdate method is called by the ring update routines. In addition, we add a dummy overlay for AWSVPC to make `weave (status| report)` to produce reasonable reports which includes AWS hosts connection state.
The endpoint returns the name of tracker. It is used to determine whether the router is running a tracker.
When running in the AWSVPC mode, we need to do the following: - Keep the HW TX offloading on. - Check that the allocated address belongs to the default subnet, because only one subnet is allowed and it should be the default one. If it is not possible to determine whether AWSVPC is on, we ignore all the steps, because the attachment routines have to work regardless whether the router is running and the AWSVPC detection is done by querying the /ipinfo/tracker endpoint served by the router.
This requires the following additional steps: - Setting proxy_arp on on the bridge, because that's how we do the routing (check the comment at the place where we set it on). - Disable ARP requests queueing, because it introduces unnecessary delay for the first ARP request resulting in a high latency of the first packet (on t2.micro machines I've encountered ~700ms latency). Also, the queue is bounded, so we might risking to drop the requests.
Otherwise it will use the regular weavewait program which wait for the multicast route to be added.
bboreham
force-pushed
the
issues/2017-awsvpc
branch
from
9eb3249 to
c77b2e8
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be aware that all the necessary enhancements are listed in #2322.