This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Remove unnecessary netns change in attach_router #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and improve the name of the function which sends existing container data into the router
rade
force-pushed
the
cleanup_attach_router
branch
from
fafd399 to
4903c2b
Compare
rade
added a commit
that referenced
this pull request
Mar 17, 2016
Remove unnecessary netns change in attach_router
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed from #1930.
Also rename function
attach_routertopopulate_router, which describes the behaviour better.