Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitoring to object cleaner #4133

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add monitoring to object cleaner #4133

merged 1 commit into from
Nov 17, 2023

Conversation

opudrovs
Copy link
Contributor

@opudrovs opudrovs commented Nov 15, 2023 •
edited
Loading

Part of weaveworks/weave-gitops-enterprise#3043

  • Updated Explorer monitoring documentation to include the object cleaner metrics.

Notes:

  • Not sure if we need such a large screenshot which shows all parts of the Explorer dashboard. If not, I can restore the old screenshot.
  • Naming suggestions are welcome.

Questions:

  • Do we agree on calling the cleaner component officially everywhere Objects Cleaner or Object Cleaner?

I saw it called differently in different places. For now, I am calling it Objects Cleaner.

@opudrovs opudrovs added the documentation Improvements or additions to documentation label Nov 15, 2023
@opudrovs opudrovs force-pushed the WGE3043-add-monitoring-to-object-cleaner branch 7 times, most recently from fcc6c1c to ea162ab Compare November 17, 2023 00:57
@opudrovs opudrovs marked this pull request as ready for review November 17, 2023 10:10
@opudrovs opudrovs requested a review from a team November 17, 2023 10:11
enekofb
enekofb approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added minor suggestions

website/docs/explorer/operations.mdx Outdated Show resolved Hide resolved
website/docs/explorer/operations.mdx Outdated Show resolved Hide resolved
website/docs/explorer/operations.mdx Outdated Show resolved Hide resolved
website/docs/explorer/operations.mdx Outdated Show resolved Hide resolved
website/docs/explorer/operations.mdx Outdated Show resolved Hide resolved
website/docs/explorer/imgs/explorer-query-metrics.png Outdated Show resolved Hide resolved
@opudrovs
Copy link
Contributor Author

@enekofb neat suggestions, thanks!

@opudrovs opudrovs force-pushed the WGE3043-add-monitoring-to-object-cleaner branch 6 times, most recently from aa959a7 to 56d9324 Compare November 17, 2023 19:17
@opudrovs
Update Explorer monitoring documentation to include the object cleane…
82888b7 
…r metrics.

Update the Explorer dashboard screenshot.
@opudrovs opudrovs force-pushed the WGE3043-add-monitoring-to-object-cleaner branch from e0e6caf to 82888b7 Compare November 17, 2023 19:20
@opudrovs opudrovs merged commit b9493a8 into main Nov 17, 2023
19 checks passed
@opudrovs opudrovs deleted the WGE3043-add-monitoring-to-object-cleaner branch November 17, 2023 19:30
@weave-gitops-bot weave-gitops-bot mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enekofb enekofb enekofb approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opudrovs @enekofb