Add colors and exports for new EE pipelines UI #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshri
added
type/enhancement
joshri
force-pushed
the
pipeline-exports
branch
from
2835c32 to
00dd4af
Compare
opudrovs
reviewed
Oct 16, 2023
ui/lib/theme.ts
Outdated
| @@ -117,6 +119,7 @@ export const theme = (mode: ThemeTypes = ThemeTypes.Light): DefaultTheme => { | |||
| alertOriginal: "#BC3B1D", | |||
| alertDark: "#9F3119", | |||
| neutralGray: "#F6F7F9", | |||
| pipelineGray: "dde1e9", | |||
There was a problem hiding this comment.
The hashtag symbol is missing.
opudrovs
reviewed
Oct 16, 2023
ui/lib/theme.ts
Outdated
| @@ -126,6 +129,7 @@ export const theme = (mode: ThemeTypes = ThemeTypes.Light): DefaultTheme => { | |||
| grayToPrimary: "#737373", | |||
| neutral20ToPrimary: "#d8d8d8", | |||
| backGray: "#eef0f4", | |||
| pipelinesBackGray: "eef0f4", | |||
There was a problem hiding this comment.
Same here, the hashtag symbol is missing.
jpellizzari
approved these changes
Oct 16, 2023
joshri
force-pushed
the
pipeline-exports
branch
from
00dd4af to
2bd1d30
Compare
TheGostKasper
approved these changes
Oct 16, 2023
opudrovs
approved these changes
Oct 16, 2023
joshri
force-pushed
the
pipeline-exports
branch
from
2bd1d30 to
7232409
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new colors to the theme, and exports where needed, and makes one important modification:
Previously, we had both
blackandneutral40switching between1a1a1aandfffin light and dark mode respectively...so they were doing the exact same thing. In the new pipelines UI, we have a case where black needs to stay black in both light and dark mode, so I've made it soblackandwhitein our theme will stay their respective colors no matter the theme, while theneutralvariants will switch. This is nice regardless as it gives some extra consistency - so you'll see every use ofwhiteandblackwe currently have will be changed to theirneutralvariants in this PR.