WGE install pages updates #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasomethingsomething
added
the
user-guide
Himangini
reviewed
Aug 8, 2023
Co-authored-by: Himangini <[email protected]>
darrylweaver
approved these changes
Aug 9, 2023
Co-authored-by: Max Jonas Werner <[email protected]>
foot
reviewed
Aug 9, 2023
Reverse order of two prereqs
- Avoid them showing up in the TOC on the right hand side as those links don't work for inactive tab, and appear sequentially which is a bit confusing - Slightly "Discourage" user deep linking to them, as that often won't work with the inactive tabs. - More emphasis you're finished with the tabbed section as we're back to another bigger heading
foot
reviewed
Aug 10, 2023
foot
reviewed
Aug 10, 2023
foot
reviewed
Aug 10, 2023
foot
reviewed
Aug 10, 2023
foot
reviewed
Aug 14, 2023
| - apiGroups: [ "" ] | ||
| resources: [ "namespaces" ] | ||
| verbs: [ "get", "list" ] | ||
| ``` |
There was a problem hiding this comment.
We don't let you configure this very much inn EE yet =/, (the comments here don't apply), and the EE SA has a few more permissions for GitopsCluster and Cluster. It looks like this if we wanna include it here.
rules:
- apiGroups: [""]
resources: ["users", "groups"]
verbs: ["impersonate"]
- apiGroups:
- ""
resources:
- secrets
verbs:
- get
- list
- watch
- apiGroups:
- cluster.x-k8s.io
resources:
- clusters
verbs:
- get
- list
- watch
- apiGroups:
- gitops.weave.works
resources:
- gitopsclusters
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- gitops.weave.works
resources:
- gitopsclusters/finalizers
verbs:
- update
- apiGroups:
- gitops.weave.works
resources:
- gitopsclusters/status
verbs:
- get
- patch
- updateThere was a problem hiding this comment.
@foot Made the changes based on the above -- maybe take a quick look to make sure it's typo-free?
foot
reviewed
Aug 14, 2023
foot
reviewed
Aug 14, 2023
foot
reviewed
Aug 14, 2023
Removes unavailable Helm values
Co-authored-by: Simon <[email protected]>
Removes impersonation section
Removes unavailable restriction
Update code
This reverts commit 64b01f3.
- WGE doesn't support that
foot
approved these changes
Aug 15, 2023
lasomethingsomething
pushed a commit
that referenced
this pull request
Aug 15, 2023
This reverts commit e648806.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates two of the primary pages related to WGE installation. Partly fixes #3886