Improve gitops run bootstrap questions #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
approved these changes
Oct 13, 2022
|
I see two more prompts with question marks left. |
This contains 2 fixes: * Remove question mark from questions - promptui already adds them. * Don't forward errors from promptui - error is how it signals a negative answer, and that's OK.
ozamosi
force-pushed
the
improve-bootstrap-question-ui
branch
from
013c364 to
e378a2f
Compare
|
🤦 This is what happens when you try to do a quick fix. 4 question marks removed. |
|
Well, it was a quick 50% fix. Still not bad. 😸 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains 2 fixes:
This addresses comments from #2871