Change wizard's questions, defaults #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
approved these changes
Oct 12, 2022
This removes a few of the questions. I removed the path, because I couldn't decide which path it should be - cluster, "current", or workload? If you change it, what happens to all the other ones, do they adjust "automatically" or not? For ssh-hostname and token-auth, it just looked like extra work to figure out how it works. For teams, I'm unsure how to test them, so leaving that as out of scope. On the other hand, it does add a question for your PAT. Because if we don't ask for a PAT, then flux will, and I don't want it to, so now we ask for it. Meanwhile, for defaults, I've added defaults everywhere, and removed the old isRequired because everything we ask is really required. For defaults, I've made the code highly opportunistic - if it guesses wrong, that's OK, you can just change it, so let's guess everything. As a result, I've removed any text that mentions the default - the default is now whatever we guessed. For booleans, you almost by definition have a default (because the absence of it being true means it's false) - I'm sure my defaults aren't the best ones, but that's OK, because you can change them (for what it's worth, "private" only affects repository creation, so it's only if it's a brand new repo that's important).
ozamosi
force-pushed
the
wizard-questions-defaults
branch
from
72399d2 to
ab18697
Compare
This was referenced Oct 13, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a few of the questions.
I removed the path, because I couldn't decide which path it should be - cluster, "current", or workload? If you change it, what happens to all the other ones, do they adjust "automatically" or not?
For ssh-hostname and token-auth, it just looked like extra work to figure out how it works.
For teams, I'm unsure how to test them, so leaving that as out of scope.
On the other hand, it does add a question for your PAT. Because if we don't ask for a PAT, then flux will, and I don't want it to, so now we ask for it.
Meanwhile, for defaults, I've added defaults everywhere, and removed the old isRequired because everything we ask is really required.
For defaults, I've made the code highly opportunistic - if it guesses wrong, that's OK, you can just change it, so let's guess everything. As a result, I've removed any text that mentions the default - the default is now whatever we guessed.
For booleans, you almost by definition have a default (because the absence of it being true means it's false) - I'm sure my defaults aren't the best ones, but that's OK, because you can change them (for what it's worth, "private" only affects repository creation, so it's only if it's a brand new repo that's important).