Improve gitops run context handling #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
approved these changes
Oct 11, 2022
ozamosi
force-pushed
the
context
branch
2 times, most recently
from
5991e72 to
e5f3511
Compare
added 2 commits
October 11, 2022 15:22
Before this, hitting ctrl+c in the middle of syncing would just keep printing error messages from the sync process about the bucket not responding which is not exactly unexpected when the frontend process has deleted the bucket. Now hitting ctrl+c in the "wrong" place will interrupt uploading and syncing - granted, it will still look ugly in places with messages about "context cancelled", but it will stop immediately.
This means I can hit ctrl+c while the bucket is still installing, and still reach the bootstrap wizard.
This was referenced Oct 13, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains 2 changes:
This allows us to do proper context handling. This PR doesn't do very good context handling, but it does sufficient context handling so that file uploads stop when hitting ctrl+c.
In other words, once you hit ctrl+c, the watcher's context will immediately abort, and thus no more transfers will happen. We might still print a warning or two about the closed context which can be improved with follow-up patches, but this means I no longer need to wait a long time for the watcher to finish before I can use the bootstrap UI.