Fix styling bug on filter chips #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried submitting text strings consisting of space characters only. Submitted the following strings individually Is it expected behavior or is it beyond the scope of this issue?
|
|
I think space characters are okay, I was focused on just pressing enter with nothing typed in the field. It might be worth trimming white space on the ends of submissions though |
|
Sounds good. Can we have a search term ending with a space or spaces? What columns are we searching within now? Can their values have spaces? |
opudrovs
approved these changes
Oct 5, 2022
|
Just noticed, a test is failing. Otherwise it LGTM! |
This was referenced Oct 13, 2022
Closed
Merged
foot
pushed a commit
that referenced
this pull request
Oct 14, 2022
* fix chip overflow, display of empty text search * snap * overflow hidden not needed * snaps again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2784
ChipOverflow.mov