Time Travel timestamps as strings, durations as numbers #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
58-make-time-travel-timestamp-params-strings
branch
from
8eb509c to
7c5f922
Compare
fbarl
force-pushed
the
58-make-time-travel-timestamp-params-strings
branch
from
7c5f922 to
478d84b
Compare
fbarl
changed the title
jpellizzari
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58.
Keeping timestamp arguments as plain strings removes the client app's dependency on
moment.jsand more importantly, enables React to do shallow comparison ofpropsand be smarter about whether they've changed.To make sure it works well in context of Weave Cloud, it might be best to test by proxying
service-uiwith bothscopeandui-componentsrepos, e.g.PROXY_SCOPE_COMPONENT=true SCOPE_PATH=/home/fbarl/Projects/weaveworks/scope/ PROXY_COMPONENTS=true COMPONENT_LIB_PATH=/home/fbarl/Projects/weaveworks/ui-components/ SERVICE_HOST=frontend.dev.weave.works yarn start