Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PrivatePage container to wrap internal components #713

Merged
merged 2 commits into from
Aug 2, 2016

Conversation

davkal
Copy link

@davkal davkal commented Aug 1, 2016

  • PrivatePage wraps components that are only accessible when logged in
  • PrivatePage contains the toolbar
  • It does a cookie-check and redirects to login when no cookie

Fixes #702
Fixes #679
Fixes #524 (when weaveworks/scope#1734 is done)

* PrivatePage wraps components that are only accessible when logged in
* PrivatePage contains the toolbar
* It does a cookie-check and redirects to login when no cookie

Fixes #702
Fixes #679
style={styles.toolbarOrganization}>

View Instance
<span style={styles.toolbarOrganizationName}>
{this.props.organization}
{this.props.instance.name}

This comment was marked as abuse.

This comment was marked as abuse.

@foot
Copy link
Contributor

foot commented Aug 1, 2016

There's still some auth-checking stuff in org/page and account/page that would be nice to remove, but could also be chore'd, other than that LGTM.

@davkal davkal merged commit 8e870c7 into master Aug 2, 2016
@davkal davkal deleted the private-wrapper branch August 2, 2016 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants