-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flux package with new listImages fields and query parameters #2045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Aaron.
(NB before we start using the new argument to the HTTP API, we'll need to make sure responses from old daemons are patched.)
The |
flux-api/bus/nats/bus.go
Outdated
@@ -6,6 +6,8 @@ import ( | |||
"strings" | |||
"time" | |||
|
|||
"github.com/weaveworks/flux/api/v10" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
flux-api/http/server.go
Outdated
@@ -150,15 +151,29 @@ func (s Server) listServices(w http.ResponseWriter, r *http.Request) { | |||
} | |||
|
|||
func (s Server) listImages(w http.ResponseWriter, r *http.Request) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks Aaron 🎇
198e93a
to
d951c65
Compare
Part of fluxcd/flux#913
listImages
endpoint updated in Add ListImages summary fields fluxcd/flux#1084