Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flux package with new listImages fields and query parameters #2045

Merged
merged 6 commits into from
Jun 13, 2018

Conversation

aaron7
Copy link

@aaron7 aaron7 commented May 25, 2018

Part of fluxcd/flux#913

@aaron7 aaron7 requested a review from squaremo May 25, 2018 13:21
squaremo
squaremo previously approved these changes May 29, 2018
Copy link
Contributor

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Aaron.

(NB before we start using the new argument to the HTTP API, we'll need to make sure responses from old daemons are patched.)

@squaremo squaremo dismissed their stale review May 29, 2018 12:24

Tests are failing, for a good reason

@squaremo
Copy link
Contributor

The flux-api/bus package will need to be updated too. Sorry!

@@ -6,6 +6,8 @@ import (
"strings"
"time"

"github.com/weaveworks/flux/api/v10"

This comment was marked as abuse.

@@ -150,15 +151,29 @@ func (s Server) listServices(w http.ResponseWriter, r *http.Request) {
}

func (s Server) listImages(w http.ResponseWriter, r *http.Request) {

This comment was marked as abuse.

@aaron7 aaron7 requested a review from squaremo June 12, 2018 16:36
Copy link
Contributor

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks Aaron 🎇

@aaron7 aaron7 force-pushed the flux-update-listIm branch from 198e93a to d951c65 Compare June 13, 2018 14:23
@aaron7 aaron7 merged commit 477911e into master Jun 13, 2018
@aaron7 aaron7 deleted the flux-update-listIm branch June 13, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants