set TERM=xterm on execs to work around docker issue 9299 #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,7 +99,7 @@ func (r *registry) execContainer(containerID string, req xfer.Request) xfer.Resp | |||
| AttachStdout: true, | |||
| AttachStderr: true, | |||
| Tty: true, | |||
| Cmd: []string{"/bin/sh"}, | |||
| Cmd: []string{"/usr/bin/env", "TERM=xterm", "/bin/sh", "-l"}, | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
paulbellamy
force-pushed
the
759-term-env-var
branch
from
72db24d to
e49d1a7
Compare
|
LGTM |
paulbellamy
added a commit
that referenced
this pull request
Feb 19, 2016
set TERM=xterm on execs to work around docker issue 9299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #759
docker run -t ...injectsTERM=xterminto the container, butdocker exec -t ...doesn't. We can inject it ourselves via env to work around this issue.