Add debug logging #935
Merged
Add debug logging #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
debug-logging
branch
from
c95db64 to
12b633f
Compare
| @@ -9,6 +8,7 @@ import ( | |||
|
|
|||
| "github.com/gorilla/mux" | |||
|
|
|||
| . "github.com/weaveworks/scope/common/log" | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@peterbourgon Weave uses dots for logging throughout it's sourcecode (that's where I took this from). Anyways, I discussed it with @tomwilkie and I am going to use logrus directly, reusing weave's formatter for uniformity. |
2opremio
force-pushed
the
debug-logging
branch
2 times, most recently
from
c00b6cf to
8b8a332
Compare
| @@ -32,16 +32,19 @@ func appMain() { | |||
| var ( | |||
| window = flag.Duration("window", 15*time.Second, "window") | |||
| listen = flag.String("http.address", ":"+strconv.Itoa(xfer.AppPort), "webserver listen address") | |||
| logLevel = flag.String("log-level", "info", "logging threshold level: debug|info|warn|error|fatal|panic") | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I'd vote for not aliasing the logrus import, but if you feel strongly that it should be aliased to |
2opremio
force-pushed
the
debug-logging
branch
from
5ec4e53 to
3d94082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.