Periodically check for newer versions of scope. #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
version-check
branch
2 times, most recently
from
16feabb to
79b73de
Compare
| if err != nil { | ||
| log.Printf("Error checking version: %v", err) | ||
| } else if r.Outdated { | ||
| log.Printf("Scope version %s is availible; please update at %s", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Logging it seems fine, but users are unlikely to see that. Would be nicer to show it when launching, and/or in the UI. |
|
I've made a separate ticket for displaying this in the UI: #914 I'd prefer not to show it on startup, due to the way our startup works (starting a container etc). |
|
Also, we should document how the user can disable this. |
tomwilkie
force-pushed
the
version-check
branch
from
79b73de to
73b8361
Compare
|
Updated to once every 6hrs on @pidster's request. |
| @@ -56,6 +56,13 @@ such, the Scope app endpoint (port 4040) should not be made accessible on | |||
| the Internet. Additionally traffic between the app and the probe is currently | |||
| insecure and should not traverse the internet. | |||
|
|
|||
| Scope will periodically check with our servers to see if a new version is | |||
| availible. To disable this, run: | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
force-pushed
the
version-check
branch
from
73b8361 to
34ca87c
Compare
paulbellamy
added a commit
that referenced
this pull request
Feb 4, 2016
Periodically check for newer versions of scope.
| @@ -90,8 +90,14 @@ check_not_running() { | |||
| } | |||
|
|
|||
| launch_command() { | |||
| local args="-v /etc/weave:/etc/weave" | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every 2 hours, hit https://checkpoint-api.weave.works looking for current versions of Scope. If a new version is found, log it.
Reuses the same library as Hashicorp's products.