Details panel table header looks up label in all rows #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes sorting of rows that have a missing metrics (0 vs null) Fixes #891
davkal
force-pushed
the
891-fix-details-columns
branch
from
e9872c1 to
9c4b4e2
Compare
|
Wicked. LGTM. |
davkal
added a commit
that referenced
this pull request
Feb 1, 2016
Details panel table header looks up label in all rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loop across all child nodes to find column labels in case first node does not have metrics (happens with stopped containers).
Fixes #891