Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable npm progress to speed up build #894

Merged
merged 1 commit into from
Feb 1, 2016
Merged

Disable npm progress to speed up build #894

merged 1 commit into from
Feb 1, 2016

Conversation

davkal
Copy link
Contributor

@davkal davkal commented Feb 1, 2016

Seems to shave 1 min off the ui-build:

Before: https://circleci.com/gh/weaveworks/scope/2734
After: https://circleci.com/gh/weaveworks/scope/2733

But that's only one data point.

@foot
Copy link
Contributor

foot commented Feb 1, 2016

I read about this somewhere!

Testing..

@foot
Copy link
Contributor

foot commented Feb 1, 2016

Zoom zoom!

time npm install
real    2m47.253s
user    2m1.330s
sys     0m14.905s

time NPM_CONFIG_PROGRESS=false npm install
real    1m24.072s
user    0m58.488s
sys     0m11.545s

LGTM, should we put it in make too?

davkal added a commit that referenced this pull request Feb 1, 2016
@davkal
Merge pull request #894 from weaveworks/no-npm-progress
6f70e70 
Disable npm progress to speed up build
@davkal davkal merged commit 6f70e70 into master Feb 1, 2016
@davkal davkal deleted the no-npm-progress branch February 1, 2016 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@foot foot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davkal @foot