Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't need sudo when DOCKER_HOST is tcp. #888

Merged
merged 1 commit into from
Feb 2, 2016
Merged

Don't need sudo when DOCKER_HOST is tcp. #888

merged 1 commit into from
Feb 2, 2016

Conversation

tomwilkie
Copy link
Contributor

No description provided.

@peterbourgon
Copy link
Contributor

Does anyone need sudo anymore? How about if you need sudo you just sudo make?

@tomwilkie
Copy link
Contributor Author

I think a default install of docker on linux needs sudo to run things. Doing a sudo make will result in stuff in you directory being owned by root.

@peterbourgon
Copy link
Contributor

Okeedokey.

@paulbellamy
Copy link
Contributor

I don't need the SUDO bit, so unless we need it in CI, I say scrap it.

@tomwilkie
Copy link
Contributor Author

As discussed, we're going to keep the SUDO.

tomwilkie added a commit that referenced this pull request Feb 2, 2016
Don't need sudo when DOCKER_HOST is tcp.
@tomwilkie tomwilkie merged commit ab284c9 into master Feb 2, 2016
@tomwilkie tomwilkie deleted the sudo branch February 2, 2016 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants