Use argv[0] for process name, differentiate scope app and probe. #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
process-name
branch
from
3653303 to
c71ad37
Compare
|
It seems like this PR does two (somewhat) unrelated things, changing the name of the scope processes, and changing what is rendered for a process name/command. Should (at least) be 2 different commits, please. |
tomwilkie
force-pushed
the
process-name
branch
from
c71ad37 to
f8c720f
Compare
|
@paulbellamy PTAL |
|
LGTM |
tomwilkie
added a commit
that referenced
this pull request
Jan 6, 2016
Use argv[0] for process name, differentiate scope app and probe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #732 scope became a single binary, and it became hard to differentiate the app from the probe. This PR reintroduces the naming difference, and also bring the process names in scope more inline with
ps.