Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS to ES2015 #712

Merged
merged 3 commits into from
Dec 1, 2015
Merged

JS to ES2015 #712

merged 3 commits into from
Dec 1, 2015

Conversation

foot
Copy link
Contributor

@foot foot commented Dec 1, 2015

Introduces shiny new ES2015 features such as:

  • import/export for modules.
  • new class syntax for React components.
  • direct export of actions. Now you gotta import actions by name.

davkal and others added 3 commits December 1, 2015 14:29
@davkal @foot
add empty eslintignore, original source maps
2ce9de6
@davkal @foot
Move JS to ES2015
6b44546 
Refactored mixins into utils

ES2015 module exports

ES2015-style imports

WIP Fixing tests

Fixes tests after es2015 code migrations.

We we're require()ing an ES2015 module[1]. Have to make sure you account
for the .default in this case.

[1] We had to use ES5 `require` in Jest:
(https://github.com/babel/babel-jest/issues/16)
@foot
Fixes small ES2015 errors introduced while rebasing.
4b33e32
@davkal
Copy link
Contributor

davkal commented Dec 1, 2015

LGTM

foot added a commit that referenced this pull request Dec 1, 2015
@foot
Merge pull request #712 from weaveworks/es2015
16635ab 
JS to ES2015
@foot foot merged commit 16635ab into master Dec 1, 2015
@foot foot deleted the es2015 branch December 1, 2015 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davkal davkal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foot @davkal