-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a spinner while node details are loading #691
Conversation
davkal
commented
Nov 20, 2015
cool |
dc4a5cf
to
b4aae3b
Compare
b4aae3b
to
e60d64d
Compare
@2opremio PTAL. |
@davkal LGTM, however, I've noticed that if you click on nodes while they are in the background, their detail requests end up somehow queuing (?) and displaying when you are no longer interested. |
You are right, when clicked, the details panel should go back to Loading mode. |
Will test this tomorrow. Why are tests failing BTW? |
Edge test ... |
yeah, unrelated. |
Ah now I know what u mean. Will see how/if this can be fixed. |
LGTM |
Show a spinner while node details are loading