Add 'latest' CRDT, make UI update quicker. #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
latest-map
branch
2 times, most recently
from
1d46b66 to
5dd87bd
Compare
9 tasks
tomwilkie
changed the title
Also use same technique to merge the controls, returning the latest set of controls instead of the union.
| cp.Node.Edges = report.EdgeMetadatas{} // snip | ||
| cp.Node.Sets = report.Sets{} // snip | ||
| cp.Node.Controls = report.NodeControls{} // snip | ||
| cp.Node.Latest = report.LatestMap{} // snip |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM |
tomwilkie
added a commit
that referenced
this pull request
Nov 9, 2015
Add 'latest' CRDT, make UI update quicker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to have an alternative to the metadata map on each node, where the merge results are deterministic (pick the latest value). This should allow us to propagate state changes faster in the UI, as we don't have to wait for the 15s window to pass.
Also using this as an opportunity to try some of the persistent datatypes, to help address #502.