Build js in docker image #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build runs through using but there is no @tomwilkie any idea? |
| RUN npm install | ||
|
|
||
| # source files are current dir | ||
| ADD . /app |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Try running with |
|
@tomwilkie relative paths dont fly. But this line works: Over to you. |
|
This fixes #12 |
tomwilkie
force-pushed
the
build-js-v2
branch
6 times, most recently
from
db3e1c1 to
5cf245d
Compare
|
@davkal this is GTG; PTAL and LGTM! |
|
Works great!
|
- Add Dockerfile for js build image - Wire up dockerized-ui build to the makefile. - Removed unused dev tools from package.json/gulp
iaguis
added a commit
to kinvolk-archives/scope
that referenced
this pull request
Jan 9, 2017
4b7d5c6 Merge pull request weaveworks#59 from weaveworks/57-fix-lint-properly b7f0e69 Merge pull request weaveworks#58 from weaveworks/fix-lint 794702c Pin version of shfmt ab1b11d Fix lint 81d80f3 Merge pull request weaveworks#55 from weaveworks/lint-tf 05ad5f2 Review feedback 4c0d046 Use hclfmt to lint terraform. fd875e2 Fix test wrt shellcheck 54ec2d9 Don't capitalise error messages 19d3b6e Merge pull request weaveworks#49 from weaveworks/pin-shfmt fea98f6 Go get from the vendor dir 1d867b0 Try and vendor a specific version of shfmt 76619c2 Merge pull request weaveworks#48 from weaveworks/revert-41-user-tokens 4f96c51 Revert "Add experimental support for user tokens" d00033f Merge pull request weaveworks#41 from weaveworks/user-tokens 245ed26 Merge pull request weaveworks#47 from weaveworks/46-shfmt c1d7815 Fix shfmt error cb39746 Don't overright lint_result with 0 when shellcheck succeeds 8ab80e8 Merge pull request weaveworks#45 from weaveworks/lint 83d5bd1 getting integration/config and test shellcheck-compliant cff9ec3 Fix some shellcheck errors 7a843d6 run shellcheck as part of lint if it is installed 31552a0 removing spurious space from test 6ca7c5f Merge pull request weaveworks#44 from weaveworks/shfmt 952356d Allow lint to lint itself b7ac59c Run shfmt on all shell files in this repo 5570b0e Add shfmt formatting of shell files in lint 0a67594 fix circle build by splatting gopath permissions 354e083 Fixing lint 586060b Add experimental support for user tokens git-subtree-dir: tools git-subtree-split: 4b7d5c6
2opremio
pushed a commit
that referenced
this pull request
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.