Improve titles and context of tables in the details pane #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2015 15:19
In situations when the details can refer to entities from multiple hosts (e.g. container image) make explicit to what host we are referring to.
2opremio
force-pushed
the
origin-host-labels
branch
from
d2bf737 to
badd228
Compare
Title modifications: * "Origin Process" -> "Process \"name\" (pid)" * "Origin Container" -> "Container \"name\" (pid)" * "Origin Host" -> "Host \"name\"" * "Origin Container Image" -> "Container Image \"name\""
2opremio
force-pushed
the
origin-host-labels
branch
from
badd228 to
75595a5
Compare
| human string | ||
| parent string | ||
| renderer render.Renderer | ||
| isMultiHost bool // does the view involve information from multiple hosts? |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@tomwilkie I've realized that providing Host context is not enough. In the Container Image view, when showing processes from containers, I should also be providing what container they belong to since they can belong to different containers. I will add that later today. |
|
Oh yes good idea. Take a look at #366 to see how I did something similar for process labels. |
2opremio
force-pushed
the
origin-host-labels
branch
from
f5b2629 to
d1126f9
Compare
| } | ||
| } | ||
| multiHost := len(originHosts) > 1 | ||
| multiContainer := len(originContainers) > 1 |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
1 comment, otherwise LGTM |
2opremio
pushed a commit
that referenced
this pull request
Aug 25, 2015
Improve titles and context of tables in the details pane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296