Naïve process walker for Darwin #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,24 +83,22 @@ func main() { | |||
| ) | |||
|
|
|||
| // TODO provide an alternate implementation for Darwin. | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
OK, I think I addressed your feedback... |
peterbourgon
force-pushed
the
process-names-on-darwin
branch
from
8fc97f8 to
32f7b22
Compare
|
Good? |
|
Yeah LGTM. Please squash, and hold until David's done the release. |
|
Of course. |
This fixes the regression where process names weren't appearing for Darwin probes. Makes testing easier. Also, changes the process walker to operate on value types. There's no performance advantage to using reference types for something of this size, and there appeared to be a data race in the Darwin port that caused nodes to gain and lose process names over time. Also, restructures how to enable docker scraping. Default false when run manually, and enabled via --probe.docker true in the scope script.
peterbourgon
force-pushed
the
process-names-on-darwin
branch
from
32f7b22 to
b585a36
Compare
peterbourgon
added a commit
that referenced
this pull request
Jul 20, 2015
Naïve process walker for Darwin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the regression where process names weren't appearing for Darwin probes. Makes testing easier.