Pick up default topology options on initial load #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this issue something that affected standalone mode too? |
I didn't test, but since all of this logic lives in Scope, I imagine there was the same issue there as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/weaveworks/service-ui/issues/1999.
As @foot discovered, the issue was actually easily reproducable - it would always show the Uncontained/Unmanaged nodes on fresh page load, regardless of the options set in the UI.
The problem was that the initial
ROUTE_TOPOLOGYhandler would settopologyOptionsto a certain value and then the condition inRECEIVE_TOPOLOGIESwould not update with the default options once they'd be received with topologies data (with a certain delay).The solution was to unconditionally update the options with defaults in
RECEIVE_TOPOLOGIESon first load, but using them only as 'fallback', still giving priority to the URL/local state options.