Replace "Origin Endpoint" tables with "Connection Details" table #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| adjacencies := endpointTopology.Adjacency[report.MakeAdjacencyID(originID)] | ||
| sort.Strings(adjacencies) | ||
| for _, adj := range adjacencies { | ||
| segments := strings.SplitN(adj, report.ScopeDelim, 3) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
paulbellamy
force-pushed
the
154-inspect-connections
branch
from
3b35dc3 to
8960015
Compare
| @@ -79,6 +79,7 @@ func MakeDetailedNode(r report.Report, n RenderableNode) DetailedNode { | |||
| // multiple origins. The ultimate goal here is to generate tables to view | |||
| // in the UI, so we skip the intermediate representations, but we could | |||
| // add them later. | |||
| connections := []Row{} | |||
| outer: | |||
| for _, id := range n.Origins { | |||
| if table, ok := OriginTable(r, id); ok { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
paulbellamy
force-pushed
the
154-inspect-connections
branch
from
8960015 to
7bbe7e6
Compare
| } { | ||
| if val, ok := nmd[tuple.key]; ok { | ||
| rows = append(rows, Row{Key: tuple.human, ValueMajor: val, ValueMinor: ""}) | ||
| local := fmt.Sprintf("%s:%s", nmd["addr"], nmd["port"]) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -103,6 +103,16 @@ func ParseNodeID(nodeID string) (hostID string, remainder string, ok bool) { | |||
| return fields[0], fields[1], true | |||
| } | |||
|
|
|||
| // ParseEndpointNodeID produces the host ID, address, and port and remainder (typically an address) from | |||
| // an endpoint node ID. Note that hostID may be blank. | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
👍 |
List Local and Remote endpoints for each TCP connection on the node.
…ction aggregation
paulbellamy
force-pushed
the
154-inspect-connections
branch
from
7bbe7e6 to
4e2f3ab
Compare
paulbellamy
force-pushed
the
154-inspect-connections
branch
from
4e2f3ab to
95f941f
Compare
paulbellamy
added a commit
that referenced
this pull request
Jul 3, 2015
Replace "Origin Endpoint" tables with "Connection Details" table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregates all connections into a single table. Only shows Local and Remote endpoints. Connection age to be added later.
Helps #154, but needs timestamps to fully fix it.