Lock styled-components version and upgrade ui-components #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron7
force-pushed
the
lock-styled-upgrade-ui-components
branch
2 times, most recently
from
0b50710 to
9ceecc8
Compare
fbarl
reviewed
Dec 11, 2017
client/yarn.lock
Outdated
| d3-interpolate "1" | ||
| d3-time "1" | ||
| d3-time-format "2" | ||
|
|
||
| d3-selection@1, [email protected]: |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
aaron7
force-pushed
the
lock-styled-upgrade-ui-components
branch
from
9ceecc8 to
71a608d
Compare
fbarl
approved these changes
Dec 12, 2017
client/package.json
Outdated
| "styled-components": "^2.2.1", | ||
| "weaveworks-ui-components": "git+https://github.com/weaveworks/ui-components.git#v0.2.1", | ||
| "styled-components": "2.2.4", | ||
| "weaveworks-ui-components": "0.3.6", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
aaron7
force-pushed
the
lock-styled-upgrade-ui-components
branch
from
71a608d to
3c92e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock
styled-componentsversion. This was causing problems when the version did not match in service-ui (styled-components/styled-components#1305).Also:
d3-selectionto 1.2.0