Stop reporting ReplicaSets #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
reviewed
Dec 4, 2017
probe/kubernetes/reporter.go
Outdated
| @@ -446,7 +393,7 @@ func match(namespace string, selector labels.Selector, topology, id string) func | |||
| } | |||
| } | |||
|
|
|||
| func (r *Reporter) podTopology(services []Service, replicaSets []ReplicaSet, daemonSets []DaemonSet, statefulSets []StatefulSet, cronJobs []CronJob) (report.Topology, error) { | |||
| func (r *Reporter) podTopology(services []Service, daemonSets []DaemonSet, statefulSets []StatefulSet, cronJobs []CronJob, deployments []Deployment) (report.Topology, error) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| report.ReplicaSet, | ||
| report.MakeReplicaSetNodeID(replicaSet.UID()), | ||
| report.Deployment, | ||
| report.MakeDeploymentNodeID(deployment.UID()), |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Also, add Deployment as Pod parent.
rbruggem
force-pushed
the
probe-no-replicasets
branch
from
e51adfe to
b522443
Compare
rade
approved these changes
Dec 5, 2017
There was a problem hiding this comment.
LGTM.
Per #2662 (comment), please file an issue to move the logic from selectPodsWithDeployments.Render() to Report.Upgrade().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add Deployment as Pod parent.
Fixes #2662