Rewrite more Map-Reduces as Renderers to save garbage #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
changed the title
rade
reviewed
Nov 14, 2017
render/render.go
Outdated
| // is only ever called when m is an endpoint and we never look at endpoint counts | ||
| func (ret *joinResults) addToResults(m report.Node, id string, create func(string) report.Node) { | ||
| // incrementing a counter if nonblank, and updating the mapping from old ID to new ID | ||
| func (ret *joinResults) addToResults(m report.Node, id string, addChildren bool, create func(string) report.Node, counters ...string) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rade
reviewed
Nov 14, 2017
render/host.go
Outdated
| for _, n := range nodes.Nodes { | ||
| if n.Topology == Pseudo { | ||
| continue // Don't propagate pseudo nodes - we do this in MapEndpoint2Host | ||
| } else { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
render/process.go
Outdated
| ProcessRenderer, | ||
| ), | ||
| ) | ||
| var ProcessNameRenderer = CustomRenderer{Renderer: ProcessRenderer, RenderFunc: processes2Names} |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
With more-renderers-b I am seeing a similar improvements in allocations as above, but no improvements in runtime: master branch (each line is the best result of three runs) |
This is preparatory to future refactorings: all existing calls are to Endpoints which have no children and where we don't want a Counter. We make addChildAndChildren an obvious extension of addChild even though it adds a dead code path (we never call addChildAndChildren with an endpoint).
This is more efficient as there are typically many fewer names than processes.
bboreham
force-pushed
the
more-renderers
branch
from
5ac8737 to
fc8a474
Compare
It's more efficient as many input Nodes map onto a few hosts.
bboreham
force-pushed
the
more-renderers
branch
from
fc8a474 to
1c206fb
Compare
rade
approved these changes
Nov 22, 2017
|
I've re-run the benchmarks with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapX2Hostand to a lesser extentMapProcess2Namehave the property that they map many nodes onto fewer nodes, so looping and using the machinery injoinResultsis more effective than creating many copies of the same node and merging.Benchmarks before (c5bdebd):
after this PR: