Parsing optimisations #2937
Merged
Parsing optimisations #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
reviewed
Nov 14, 2017
render/id.go
Outdated
| @@ -66,7 +65,8 @@ func externalNodeID(n report.Node, addr string, local report.Networks) (string, | |||
|
|
|||
| // If the dstNodeAddr is not in a network local to this report, we emit an | |||
| // internet pseudoNode | |||
| if ip := net.ParseIP(addr); ip != nil && !local.Contains(ip) { | |||
| var into [5]byte // one extra byte to save a memory allocation in critbitgo | |||
| if ip := report.ParseIPb([]byte(addr), into[:4]); ip != nil && !local.Contains(ip) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
report/networks.go
Outdated
|
|
||
| // ParseIP parses s as an IP address into a byte slice if supplied, returning the result. | ||
| // (mostly copied from net.ParseIP, modified to save memory allocations) | ||
| func ParseIPb(s []byte, into []byte) net.IP { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| if second == -1 { | ||
| return "", "", "", false | ||
| } | ||
| return endpointNodeID[:first], endpointNodeID[first+1 : first+1+second], endpointNodeID[first+1+second+1:], true |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
These routines are called a lot, so this change reduces garbage collection
Pass in a slice on the stack instead of allocating one on the heap: reduces garbage, hence makes the program run faster Also apply knowledge that critbitgo will do an append() with one extra byte, so we do that allocation up-front too. This is innocuous should we stop using critbitgo or should its internals change.
bboreham
force-pushed
the
parse-optimisations
branch
from
41e33ed to
b989006
Compare
rade
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make low-level parsing more closely aligned to what we need, to save memory allocations.
See individual commit messages for more details.
These routines are called a lot, so this change reduces garbage collection
Benchmarks before (c5bdebd):
after this PR: