Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't de-reference pointers from ECS without checking #2918

Merged
merged 1 commit into from
Nov 4, 2017
Merged

Don't de-reference pointers from ECS without checking #2918

merged 1 commit into from
Nov 4, 2017

Conversation

bboreham
Copy link
Collaborator

@bboreham bboreham commented Nov 1, 2017

Fixes #2508

dlespiau
dlespiau approved these changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@dlespiau dlespiau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Not crashing will at least give us a fighting chance to go to the bottom of this.

@galindro
Copy link

galindro commented Nov 1, 2017

@bboreham I'll test your PR in my env to see if it was fixed the problem

@bboreham bboreham merged commit 6aab6ce into master Nov 4, 2017
@pecigonzalo pecigonzalo mentioned this pull request Nov 10, 2017
Closed
@dlespiau dlespiau deleted the ecs-crash-less branch November 21, 2017 08:49
@rade rade changed the title Don't de-reference pointers from AWS without checking Don't de-reference pointers from ECS without checking Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlespiau dlespiau dlespiau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bboreham @galindro @dlespiau