Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINER is deprecated, now using LABEL #2916

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

cglewis
Copy link
Contributor

@cglewis cglewis commented Oct 31, 2017

@dlespiau
Copy link
Contributor

dlespiau commented Nov 1, 2017

Indeed, from the referenced page:

MAINTAINER in Dockerfile
Deprecated In Release: v1.13.0

MAINTAINER was an early very limited form of LABEL which should be used instead.

I note there's no removal date (compare that to other deprecated features) and this introduces a dependency on docker 1.13 (Jan 2017) for build, at least. I don't see any problem with this at the moment, but we may encounter one down the line.

Still, this seems fine.

@dlespiau dlespiau merged commit 99fad2f into weaveworks:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants