Try to prevent zooming NaN errors #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2858.
Although I couldn't find the exact cause (the problem is not really reproducible, there seems to be a ~0.5% chance of running into a race condition), I believe that one of the two measures will make it vanish:
Changes
(width, height)to(0, 0)in the global state. That one gets set to proper values onceAppcomponent mounts, but we want to make sure it's a numerical value (vs.undefined) before in case the zooming selectors which depend on it pick it up before the app is mounted.NaNvalues are never cached. That means that even if we hit the same race condition, it should fix itself in the next render loop because the default zoom values will be used again instead of the cachedNaN. So if this error does happen again, I expect it would just be thrown once and then the zooming and panning would work normally again.