Update eslint dependencies

[fbarl]

Resolves #2895.

Everything should feel and work exactly as before, most of the new rules are purely syntactic. Two new rules that weren't applied have to do with converting some divs, spans and as into buttons and their scope of (semantic) changes is too big for this PR so they're left temporarily disabled.

New/updated rules

• function-paren-newline
• indent
• jsx-a11y/anchor-is-valid
• jsx-a11y/label-has-for
• jsx-a11y/no-noninteractive-element-interactions
• no-multi-spaces
• no-restricted-globals
• object-curly-newline
• padded-blocks
• prefer-destructuring
• react/default-props-match-prop-types
• react/jsx-closing-tag-location
• react/jsx-max-props-per-line
• react/jsx-wrap-multilines
• spaced-comment

Disabled rules

• jsx-a11y/click-events-have-key-events
• jsx-a11y/mouse-events-have-key-events

[jpellizzari]

Is this in sync with the service-ui eslint file? If so, LGTM.

[fbarl]

Is this in sync with the service-ui eslint file?

It's not in sync as the eslint libraries in service-ui haven't been updated yet. However, I get no issues when running PROXY_SCOPE_COMPONENT=true SCOPE_PATH=/home/fbarl/Projects/weaveworks/scope/ SERVICE_HOST=frontend.dev.weave.works npm start locally, presummably because the new rules are strictly stricter and the fixes still obey the old rules in both repos :)

p.s. There was a failing test I had to fix in the meantime but that was a one liner in a test file.