tracking: Add Mixpanel event on Control clicks #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
reviewed
Sep 22, 2017
| @@ -21,6 +22,7 @@ class NodeDetailsControlButton extends React.Component { | |||
|
|
|||
| handleClick(ev) { | |||
| ev.preventDefault(); | |||
| trackMixpanelEvent('scope.node.control.click', { id: this.props.control.id }); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
We'd like to gain some insight on how controls are used.
dlespiau
force-pushed
the
2017-09-21-control-tracking
branch
from
cc557e5 to
802559e
Compare
dlespiau
added a commit
that referenced
this pull request
Sep 26, 2017
Unfortunately, I forgot to rebase before renaming trackMixpanelEvent() and a PR adding a new trace point was already in-flight. More precisely: - #2861 renames trackMixpanelEvent() to trackAnalysticsEent() - #2857 add a new trackMixpanelEvent() call. Each PR is fine, but with the merge of both without rebasing any, we end up with master having a dandling call to trackMixpanelEvent().
dlespiau
added a commit
that referenced
this pull request
Sep 26, 2017
Unfortunately, I forgot to rebase before renaming trackMixpanelEvent() and a PR adding a new trace point was already in-flight. More precisely: - #2861 renames trackMixpanelEvent() to trackAnalysticsEent() - #2857 add a new trackMixpanelEvent() call. Each PR is fine, but with the merge of both without rebasing any, we end up with master having a dandling call to trackMixpanelEvent().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to gain some insight on how controls are used.