Adds ECS Cluster Region option #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekimekim
suggested changes
Sep 18, 2017
prog/main.go
Outdated
| kubernetesTokenFlag = "probe.kubernetes.token" | ||
| sensitiveFlags = []string{ | ||
| serviceTokenFlag = "service-token" | ||
| probeEcsClusterRegionFlag = "probe.ecs.cluster.region" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
probe/awsecs/client.go
Outdated
| region, err := ec2metadata.New(sess).Region() | ||
| if err != nil { | ||
| return nil, err | ||
| var err error |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
galindro
force-pushed
the
ecs-region
branch
from
bdeaaeb to
cd21baf
Compare
ekimekim
approved these changes
Sep 18, 2017
ekimekim
added a commit
that referenced
this pull request
Sep 19, 2017
|
@ekimekim When my commit will be tagged? I've noticed that it was mentioned in 1.6.5 changelog but, I can't see it in commit list nor in files changed |
|
It's there. Check https://github.com/weaveworks/scope/commits/v1.6.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propourse
As talked with @ekimekim on slack, this PR adds an ECS Cluster Region option.
Usage
The default behaviour is to get the region from the instance metadata.