Fix query filters by adding namespaces and using docker container name #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndstr
force-pushed
the
scope-cortex-query-filters
branch
from
f6ee1ec to
106a341
Compare
2opremio
reviewed
Aug 16, 2017
| @@ -82,17 +83,17 @@ func formatMetricQueries(filter string, ids []string) map[string]string { | |||
| // All `container_*`metrics are provided by cAdvisor in Kubelets | |||
| switch id { | |||
| case docker.MemoryUsage: | |||
| queries[id] = fmt.Sprintf("sum(container_memory_usage_bytes{%s})/1024/1024", filter) | |||
| queries[id] = fmt.Sprintf("sum(container_memory_usage_bytes{%s})", filter) | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
2opremio
reviewed
Aug 16, 2017
render/detailed/links.go
Outdated
| } | ||
|
|
||
| q := queries[metricID] | ||
| for old, new := range replacements { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM, only an optional tweak and a question. |
And get rid of B -> MB conversion Fixes #2817
rndstr
force-pushed
the
scope-cortex-query-filters
branch
from
106a341 to
34f54d1
Compare
2opremio
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.