Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove whitespace from empty connection lists #2811

Merged
merged 1 commit into from
Aug 14, 2017
Merged

Remove whitespace from empty connection lists #2811

merged 1 commit into from
Aug 14, 2017

Conversation

rndstr
Copy link
Contributor

@rndstr rndstr commented Aug 14, 2017

Removes empty container that introduce unnecessary margin
scope-details-whitespace

@rndstr rndstr requested a review from fbarl August 14, 2017 11:50
fbarl
fbarl approved these changes Aug 14, 2017
View reviewed changes
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm surprised this hasn't been fixed till now :)

p.s. I'm not exactly sure that not displaying a table is the best way of saying it's empty, but that should probably be a separate discussion.

@rndstr
Copy link
Contributor Author

rndstr commented Aug 14, 2017

Good point, maybe something like

INBOUND
No connections

OUTBOUND
No connections

@rndstr rndstr merged commit 90d0e79 into master Aug 14, 2017
@rndstr rndstr deleted the remove-ws-empty-connections branch August 14, 2017 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl fbarl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rndstr @fbarl