synthesise k8s service network from service IPs #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Aug 1, 2017
| // https://github.com/kubernetes/kubernetes/issues/25533), so instead | ||
| // we synthesise it by computing the smallest network that contains | ||
| // all service IPs. That network may be smaller than the actual range | ||
| // but that is ok, since in the end all we care about is that it |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
2opremio
reviewed
Aug 1, 2017
report/networks.go
Outdated
| a = a[:8] | ||
| b = b[:8] | ||
| } | ||
| for len(a) > 0 { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
2opremio
approved these changes
Aug 1, 2017
rade
force-pushed
the
2748-synthesise-service-network
branch
from
8a7370d to
12add72
Compare
2opremio
reviewed
Aug 1, 2017
report/networks.go
Outdated
| return &network | ||
| } | ||
|
|
||
| func commonIPv4PrefixLen(a, b net.IP) (cpl int) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This prevents cluttering host.LocalNetworks with lots of /32 addresses. These were unsightly and rather distracting in the UI. They also bloated the report and slowed down server-side rendering. Fixes #2748.
rade
force-pushed
the
2748-synthesise-service-network
branch
from
12add72 to
4dae7ed
Compare
2opremio
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents cluttering host.LocalNetworks with lots of /32 addresses. These were unsightly and rather distracting in the UI. They also bloated the report and slowed down server-side rendering.
Fixes #2748.